[PATCH] D154205: [MachineLICM] Handle subloops

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:135
     // Exit blocks for CurLoop.
     SmallVector<MachineBasicBlock *, 8> ExitBlocks;
 
----------------
jaykang10 wrote:
> dmgreen wrote:
> > Will ExitBlocks be incorrect now?
> Ah, that is good point!
> They are out-most loop's ExitBlocks.
> Let me fix it.
> Thanks for checking it.
> 
Could this use CurLoop->isLoopExiting(ExitBlocks) instead? It might be quicker for larger loops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154205/new/

https://reviews.llvm.org/D154205