[PATCH] D149288: [X86] Introduce a large data threshold for the medium code model

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/tools/llc/llc.cpp:498
   auto InitializeOptions = [&](const Triple &TheTriple) {
     Options = codegen::InitTargetOptionsFromCodeGenFlags(TheTriple);
 
----------------
rnk wrote:
> Should the threshold be a `TargetOption`? Would that avoid the need for the new TargetMachine field?
it should go along with the code model since they're tied together. I do think putting all these options (code model, relocation model) in `TargetOptions` makes sense, it fits with lots of existing options there. if we put all these options into `TargetOptions` it'd simplify the `TargetMachine` constructors. if people think this makes sense I can do that cleanup first


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149288/new/

https://reviews.llvm.org/D149288