[PATCH] D155406: [MemCpyOpt] implement multi BB stack-move optimization

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 13:39:38 PDT 2023


vitalybuka accepted this revision.
vitalybuka added a comment.

Yes, like this.

LGTM,

If you can wait a few hours I try the patch on our internal code.



================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:1611
+  // exists.
   if (!LifetimeMarkers.empty()) {
     for (Instruction *I : LifetimeMarkers)
----------------
Please drop TODO: Reconstruct merged lifetime markers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155406/new/

https://reviews.llvm.org/D155406



More information about the llvm-commits mailing list