[PATCH] D149288: [X86] Introduce a large data threshold for the medium code model

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 12:21:04 PDT 2023


efriedma added a comment.

Right, the model should be encoded in the IR for LTO.  So as long as we consider the threshold an ABI constraint, and we can accurately compute whether a global has indefinite size, we don't need to tag individual globals.

Tagging individual globals could be useful as an extension, I guess, but it doesn't need to be in this patch.

(Note there's a weird interaction between -mcmodel=medium and the gcc extension that allows initializing flexible arrays: it's possible to define a "small" global that's actually larger than the threshold, and gcc will still treat it as small.  But the interaction is consistent with the way this patch works.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149288/new/

https://reviews.llvm.org/D149288



More information about the llvm-commits mailing list