[PATCH] D158648: InstCombine: Introduce SimplifyDemandedUseFPClass

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1810
+
+  assert(Known == KnownFPClass());
+
----------------
(style) assert message


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1846
+    case Intrinsic::fabs:
+      if (SimplifyDemandedFPClass(I, 0, llvm::fabs(DemandedMask), Known,
+                                  Depth + 1))
----------------
nikic wrote:
> It seems like this is correct, but only because `fabs(FPClassTest)` apparently does the exact opposite of what one would expect it to do. It's really `inverse_fabs()`.
Do we need a llvm::inverse_fabs() ? Or at least a comment describing the behaviour


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158648/new/

https://reviews.llvm.org/D158648