[llvm] [LLVM] convergence verifier should visit all instructions (PR #66200)

[Matt Arsenault via llvm-commits]

================
@@ -3576,8 +3576,6 @@ void Verifier::visitCallBase(CallBase &Call) {
   if (Call.isInlineAsm())
     verifyInlineAsmCall(Call);
 
-  CV.visit(Call);
----------------
arsenm wrote:

If only calls can be convergent, I'm not sure I see how this is different. I don't really expect a visit instruction for the verifier to be side effecting. Can you have a separate enter block visitor?

https://github.com/llvm/llvm-project/pull/66200