[PATCH] D158517: [IR] Enable load/store/alloca for arrays of scalable vectors.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 04:18:43 PDT 2023

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Thanks for adding the extra tests.

Comment at: llvm/test/CodeGen/AArch64/alloca-load-store-scalable-array.ll:6
+%my_subtype = type <vscale x 2 x double>
+%my_type = type [3 x %my_subtype]
nit: feel free to ignore, but maybe change these names to something descriptive, e.g. `my_subtype -> my_nxv2f64` and `my_type -> 3x_my_nxv2f64`?

Comment at: llvm/test/Transforms/GlobalOpt/2022-08-23-ScalableVectorArrayCrash.ll:10
+define dso_local void @foo() local_unnamed_addr align 16 {
paulwalker-arm wrote:
> sdesmalen wrote:
> > nit: can you remove the attributes from the test that aren't strictly necessary?
> Do you mind if I don't because it's a clone of an existing test (2022-08-23-ScalableVectorCrash.ll) and I'd rather they remain in sync.  I can follow up and clean both together if that's ok?
Sure, cleaning it as a follow-up patch is fine to me.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list