[llvm] [ci] builkite don't escape windows targets (PR #66192)

Mikhail Goncharov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 04:01:46 PDT 2023


https://github.com/metaflow created https://github.com/llvm/llvm-project/pull/66192:

ninja takes every target as a separate argument

>From 436d6dee6a14179eb331cab080880961d522bec9 Mon Sep 17 00:00:00 2001
From: Mikhail Goncharov <goncharov.mikhail at gmail.com>
Date: Wed, 13 Sep 2023 13:01:20 +0200
Subject: [PATCH] [ci] builkite don't escape windows targets

ninja takes every target as a separate argument
---
 .ci/monolithic-linux.sh   | 3 ++-
 .ci/monolithic-windows.sh | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.ci/monolithic-linux.sh b/.ci/monolithic-linux.sh
index 03cf38b90c08fd8..311488b2c2878b1 100755
--- a/.ci/monolithic-linux.sh
+++ b/.ci/monolithic-linux.sh
@@ -52,4 +52,5 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D LLVM_CCACHE_BUILD=ON
 
 echo "--- ninja"
-ninja -C ${BUILD_DIR} ${targets}
+# Targets are not escaped as they are passed as separate arguments.
+ninja -C "${BUILD_DIR}" ${targets}
diff --git a/.ci/monolithic-windows.sh b/.ci/monolithic-windows.sh
index 83be9d04b992781..00c3037c4c4fd61 100755
--- a/.ci/monolithic-windows.sh
+++ b/.ci/monolithic-windows.sh
@@ -51,4 +51,5 @@ cmake -S ${MONOREPO_ROOT}/llvm -B ${BUILD_DIR} \
       -D CMAKE_CXX_COMPILER_LAUNCHER=sccache
 
 echo "--- ninja"
-ninja -C "${BUILD_DIR}" "${targets}"
+# Targets are not escaped as they are passed as separate arguments.
+ninja -C "${BUILD_DIR}" ${targets}



More information about the llvm-commits mailing list