[llvm] [MachineBasicBlock] Fix use after free in SplitCriticalEdge (PR #66188)

[via llvm-commits]

================
@@ -682,7 +683,8 @@ class TargetInstrInfo : public MCInstrInfo {
   /// If \p BytesRemoved is non-null, report the change in code size from the
   /// removed instructions.
   virtual unsigned removeBranch(MachineBasicBlock &MBB,
-                                int *BytesRemoved = nullptr) const {
+                                int *BytesRemoved = nullptr,
----------------
qcolombet wrote:

+1 on that if we decide to go with the additional parameter. Otherwise you'll have to add the related `/*BytesRemoved=*/`, `/*BytesAdded=*/` everywhere.

https://github.com/llvm/llvm-project/pull/66188