[llvm] 8ebe1d1 - Revert "[NFC]Add assert to avoid possibly deref nullptr (#65564)" (#66187)

via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 13 02:14:33 PDT 2023


Author: XinWang10
Date: 2023-09-13T17:14:29+08:00
New Revision: 8ebe1d1cc1e411c3b967c4c08ab6038b275ecbf2

URL: https://github.com/llvm/llvm-project/commit/8ebe1d1cc1e411c3b967c4c08ab6038b275ecbf2
DIFF: https://github.com/llvm/llvm-project/commit/8ebe1d1cc1e411c3b967c4c08ab6038b275ecbf2.diff

LOG: Revert "[NFC]Add assert to avoid possibly deref nullptr (#65564)" (#66187)

This reverts commit 99fb65fa7a65b9a3f961d6ef715324c2f8637766 because it
won't benefit.

Added: 
    

Modified: 
    llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
    llvm/lib/Target/X86/X86AsmPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
index d6add5768951cd3..d0ef3e5a19391cc 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
@@ -400,7 +400,6 @@ void AsmPrinter::emitInlineAsm(const MachineInstr *MI) const {
         "Reserved registers on the clobber list may not be "
         "preserved across the asm statement, and clobbering them may "
         "lead to undefined behaviour.";
-    assert(MMI && "MMI can not be nullptr!");
     MMI->getModule()->getContext().diagnose(DiagnosticInfoInlineAsm(
         LocCookie, Msg, DiagnosticSeverity::DS_Warning));
     MMI->getModule()->getContext().diagnose(

diff  --git a/llvm/lib/Target/X86/X86AsmPrinter.cpp b/llvm/lib/Target/X86/X86AsmPrinter.cpp
index d09732274f5c1df..bb94444525fb89a 100644
--- a/llvm/lib/Target/X86/X86AsmPrinter.cpp
+++ b/llvm/lib/Target/X86/X86AsmPrinter.cpp
@@ -769,7 +769,6 @@ void X86AsmPrinter::emitStartOfAsmFile(Module &M) {
       if (!TT.isArch32Bit() && !TT.isArch64Bit())
         llvm_unreachable("CFProtection used on invalid architecture!");
       MCSection *Cur = OutStreamer->getCurrentSectionOnly();
-      assert(MMI && "MMI can not be nullptr!");
       MCSection *Nt = MMI->getContext().getELFSection(
           ".note.gnu.property", ELF::SHT_NOTE, ELF::SHF_ALLOC);
       OutStreamer->switchSection(Nt);


        


More information about the llvm-commits mailing list