[PATCH] D153587: [GlobPattern] Support brace expansions

Tue Sep 12 16:57:48 PDT 2023

ellis added a comment.

In D153587#4644735 <https://reviews.llvm.org/D153587#4644735>, @srj wrote:

> This has injected a build break in an older-but-still-supported version of gcc (at least, I think it's supported): `arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0`, in which we get failures on lines 62 and 132 of the form
>
>   `GlobPattern.cpp: In function ‘llvm::Expected<llvm::SmallVector<std::__cxx11::basic_string<char>, 1> > parseBraceExpansions(llvm::StringRef, std::optional<unsigned int>)’:
>   GlobPattern.cpp:62:12: error: could not convert ‘SubPatterns’ from ‘llvm::SmallVector<std::__cxx11::basic_string<char> >’ to ‘llvm::Expected<llvm::SmallVector<std::__cxx11::basic_string<char>, 1> >’`
>
> In both cases, replacing the `return SubPatterns;` with `return std::move(SubPatterns);` heals the misbehavior. Could we please get a patch to update this to unbreak our 32-bit builds?
>
> (Yes, gcc7.5 is probably getting a bit long in the tooth here, and we're looking to upgrade; unfortunately, we are temporarily hamstrung by some ancient build infrastructure that is essentially incapable of being easily upgraded to newer builds, and it will take us a little time to figure out good replacements, unfortunately.)
>
> UPDATE: I just realized that pull requests from GitHub are now being accepted, so I went and opened one myself to fix this: https://github.com/llvm/llvm-project/pull/66155

Thanks for letting me know. I've just pushed a fix at https://github.com/llvm/llvm-project/commit/dfd0cd1cc182789d351953d2c40b8ccd9fdec34f so let me know if it starts building or not

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153587/new/

https://reviews.llvm.org/D153587