[PATCH] D155856: [HIP][LLVM][Opt][RFC] Add LLVM support for C++ Parallel Algorithm Offload

[Alex Voicu via Phabricator via llvm-commits]

AlexVlx added inline comments.


================
Comment at: llvm/lib/Transforms/HipStdPar/HipStdPar.cpp:73
+
+  if (!G.isConstantUsed())
+    return true;
----------------
AlexVlx wrote:
> yaxunl wrote:
> > Is this condition correct?
> > 
> > AMDGPU backend supports non-constant TLS?
> Typo, will fix, good catch!
Actually, scratch that, I misremembered -> the predicate should read as `Is this Constant Used?` and not `Is only ConstantUsed` i.e. it returns true iff there are non-constant uses, so we only early out iff there are ONLY constexpr uses. So yes, the condition is correct, but the predicate is confusing, a bit:)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155856/new/

https://reviews.llvm.org/D155856