[PATCH] D159131: [RISCV][GlobalISel] Select G_ICMP

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVInstructionSelector.cpp:164
+  switch (MI.getOpcode()) {
+  case TargetOpcode::G_ICMP: {
+    MachineOperand *SrcOps[2] = {&MI.getOperand(2), &MI.getOperand(3)};
----------------
arsenm wrote:
> This is pretty ugly, I thought tablegen already did something for the pointer types to the int patterns here?
We found this patch that was never merged https://reviews.llvm.org/D55914 . Should we re-consider that patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159131/new/

https://reviews.llvm.org/D159131