[PATCH] D159410: [BOLT] skip CFG verification after the 'inst-lowering' Pass

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 12:45:24 PDT 2023


maksfb added a comment.

I agree that we shouldn't validate CFG after the instruction lowering pass. Thanks for the fix and for providing the explanation.

Implementation-wise, I think we should make the validation requirement even stronger. Once a CFG is finalized, i.e. a function is in `CFG_Finalized` state, we should skip the check. You can simply return `true` from `validateCFG()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159410/new/

https://reviews.llvm.org/D159410



More information about the llvm-commits mailing list