[lld] [LLD][AARCH64] lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 11:05:48 PDT 2023


https://github.com/smithp35 commented:

Thanks for fixing the commits, that makes it easier to review.

I can see that this would need a fix in relocateAlloc. I think you'll need to update the generic one in Target.cpp as well as the Target specific ones for x86_64 and PPC (and any other I've missed).

You'll need to add x86_64, PPC and at least one other target's (for the generic Target) so that we've covered all the code-paths. By replacing the nops with a common data directive you might be able to make the same file work for all 3. However I think it would still need separate files so that the REQUIRES only had one target.

https://github.com/llvm/llvm-project/pull/65966


More information about the llvm-commits mailing list