[llvm] [Dexter] Replace clang with clang++ in various cross project tests (PR #65987)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 04:56:29 PDT 2023


SLTozer wrote:

> This change looks good by itself, but we may need to additionally sneak in `-isysroot` if any system headers are needed by the tests.

That sounds like a good candidate for some kind of system-dependent substitution; though I don't think any of the cross-project-tests right now (including the `system-darwin`-specific ones) are using `-isysroot`, so it might not be a necessary addition.

I also see that some of the tests that were XFAILed before due to greendragon test failures don't make use of `-lstdc++` and are using the correct versions of clang, so this patch likely won't fix them - will continue to investigate those cases, and add a new PR for any further fixes that fall out.

https://github.com/llvm/llvm-project/pull/65987


More information about the llvm-commits mailing list