[llvm] [mlir][bufferization] Generalize tensor slice rules to subset ops (PR #65619)
Martin Erhart via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 12 03:59:04 PDT 2023
================
@@ -1172,6 +1107,11 @@ void mlir::tensor::registerBufferizableOpInterfaceExternalModels(
ReshapeOp::attachInterface<ReshapeOpInterface>(*ctx);
SplatOp::attachInterface<SplatOpInterface>(*ctx);
+ // SubsetOpInterface models.
+ InsertSliceOp::attachInterface<InsertSliceOpSubsetOpInterface>(*ctx);
+ ParallelInsertSliceOp::attachInterface<
+ ParallelInsertSliceOpSubsetOpInterface>(*ctx);
+
----------------
maerhart wrote:
What's the rationale that this interface is not implemented in its own `SubsetOpInterfaceImpl.cpp` and registered in a separate `registerSubsetOpInterfaceExternalModels`?
https://github.com/llvm/llvm-project/pull/65619
More information about the llvm-commits
mailing list