[PATCH] D155440: ValueTracking: Make computeKnownFPClass respect UseInstrInfo

Tue Sep 12 03:09:20 PDT 2023

arsenm added a comment.

ping

================
Comment at: llvm/unittests/Analysis/ValueTrackingTest.cpp:2010
+
+  // Still looks at nofpclass attribute
+  {
----------------
arsenm wrote:
> jcranmer-intel wrote:
> > Why is `nofpclass` being looked at for UseInstrInfo = false? It doesn't make much sense for `nnan` and `nofpclass(nan)` to be treated differently...
> I don't really know what UseInstrInfo is supposed to mean, but this matched the previous behavior. The parameter is undocumented and based on SimplifyQuery it means "don't use flags" for an uncertain definition of flags.
My guess is this should also skip using assumes, but that also has never happened

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155440/new/

https://reviews.llvm.org/D155440