[PATCH] D158167: [AMDGPU] Handle isUndef flag in LiveVariables::recomputeForSingleDefVirtReg

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 12 02:14:45 PDT 2023


vpykhtin added inline comments.


================
Comment at: llvm/unittests/MI/LiveIntervalTest.cpp:1
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/CodeGen/LiveIntervals.h"
----------------
foad wrote:
> vpykhtin wrote:
> > foad wrote:
> > > I don't understand this message - does clang-format want you to change something?
> > It wants me to format most of the source, I didn't include that formatting as would create a lot of unrelated changes.
> > 
> > Maybe it worth to format the entire source after the commit.
> > It wants me to format most of the source
> 
> Generally you should run "git clang-format @^" to reformat only the parts that your patch has modified.
Thank you, I didn't know that. I've relied on the formatting of arc diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158167/new/

https://reviews.llvm.org/D158167



More information about the llvm-commits mailing list