[PATCH] D158882: RegisterCoalescer: Don't delete IMPLICIT_DEF if it's live into the same block

Mon Sep 11 23:09:19 PDT 2023

arsenm added inline comments.

================
Comment at: llvm/test/CodeGen/X86/pr38795.ll:2-3
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39440.
 ; RUN: llc %s -O2 -mtriple=i386-unknown-linux-gnu -o - -verify-machineinstrs=0 | FileCheck %s
 @.str = external dso_local unnamed_addr constant [6 x i8], align 1
----------------
bjope wrote:
> bjope wrote:
> > I guess we want to do this now. I.e. enable verify-machineinstrs.
> > 
> > (PR39440 == GH issue 38788)
> > 
> > 
> Still think you want to remove the FIXME and enabe the verifier, right?
> (LGTM otherwise.)
Only in the next patch, the first one doesn't fix it

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158882/new/

https://reviews.llvm.org/D158882