[PATCH] D158011: Make _LIBUNWIND_SUPPORT_FRAME_APIS not conditional on target architecure.

Mon Sep 11 21:47:03 PDT 2023

MaskRay added a comment.

In D158011#4643901 <https://reviews.llvm.org/D158011#4643901>, @glandium wrote:

> It's really confusing that the commit that landed says:
>
>> Default this to on, so as not to remove the apis from environments that already have them.
>
> FWIW, this is used by rust on i686 mingw: https://github.com/rust-lang/rust/blob/36b8e4aa7588c70947419a5b435b6faa66669cbd/library/rtstartup/rsbegin.rs#L82

Note that these `__register_frame_*` symbols are empty in llvm-project/libunwind and do not really work.
rust i686 mingw should use weak references like GCC `libgcc/crtstuff.c` does. mingw supports `.refptr.` to make an unresolved symbol value 0.
(I probably should add more detail to https://maskray.me/blog/2021-04-25-weak-symbol when I understand mingw better...)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158011/new/

https://reviews.llvm.org/D158011