[PATCH] D159460: [BOLT][NFC] Speedup YAML profile processing
Amir Ayupov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 11 15:28:19 PDT 2023
Amir marked an inline comment as done.
Amir added inline comments.
================
Comment at: bolt/include/bolt/Profile/YAMLProfileReader.h:84
/// Update matched YAML -> BinaryFunction pair.
- void matchProfileToFunction(yaml::bolt::BinaryFunctionProfile &YamlBF,
+ bool matchProfileToFunction(yaml::bolt::BinaryFunctionProfile &YamlBF,
BinaryFunction &BF) {
----------------
maksfb wrote:
> Is the change to always return `true` necessary?
Not really, just to avoid curly braces in `matchProfile` lambda. Reverted this change back to returning `void` and added curly braces down below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159460/new/
https://reviews.llvm.org/D159460
More information about the llvm-commits
mailing list