[PATCH] D155579: [Windows] Avoid using FileIndex for unique IDs on network mounts
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 11 13:21:11 PDT 2023
mstorsjo added inline comments.
================
Comment at: llvm/unittests/Support/Path.cpp:714
// same unique id. We can test this by making a hard link.
+ // Our implementation of getUniqueID on Windows doesn't consider hard links
+ // being the same file.
----------------
aaron.ballman wrote:
> Would this make sense?
I guess that makes sense, although it’s a bit problematic to fix (without trading in the other bugs we’re trying to fix here). I hope that if someone tries to fix it, that they check up on why we ended up here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155579/new/
https://reviews.llvm.org/D155579
More information about the llvm-commits
mailing list