[llvm] [libc] Add is_object (PR #65749)

[Guillaume Chatelet via llvm-commits]

https://github.com/gchatelet updated https://github.com/llvm/llvm-project/pull/65749:

>From 3edc4c95e4824782b941079cf9bb18dbef5e0582 Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet <gchatelet at google.com>
Date: Fri, 8 Sep 2023 11:26:07 +0000
Subject: [PATCH 1/3] [libc] Add is_object

---
 libc/src/__support/CPP/type_traits.h          |  1 +
 .../src/__support/CPP/type_traits/is_object.h | 30 +++++++++++++++++++
 .../llvm-project-overlay/libc/BUILD.bazel     |  1 +
 3 files changed, 32 insertions(+)
 create mode 100644 libc/src/__support/CPP/type_traits/is_object.h

diff --git a/libc/src/__support/CPP/type_traits.h b/libc/src/__support/CPP/type_traits.h
index c0d3591f8d37eb8..9deb08b221593e1 100644
--- a/libc/src/__support/CPP/type_traits.h
+++ b/libc/src/__support/CPP/type_traits.h
@@ -32,6 +32,7 @@
 #include "src/__support/CPP/type_traits/is_lvalue_reference.h"
 #include "src/__support/CPP/type_traits/is_member_pointer.h"
 #include "src/__support/CPP/type_traits/is_null_pointer.h"
+#include "src/__support/CPP/type_traits/is_object.h"
 #include "src/__support/CPP/type_traits/is_pointer.h"
 #include "src/__support/CPP/type_traits/is_reference.h"
 #include "src/__support/CPP/type_traits/is_rvalue_reference.h"
diff --git a/libc/src/__support/CPP/type_traits/is_object.h b/libc/src/__support/CPP/type_traits/is_object.h
new file mode 100644
index 000000000000000..9928fb7b85e3d82
--- /dev/null
+++ b/libc/src/__support/CPP/type_traits/is_object.h
@@ -0,0 +1,30 @@
+//===-- is_object type_traits -----------------------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#ifndef LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H
+#define LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H
+
+#include "src/__support/CPP/type_traits/bool_constant.h"
+#include "src/__support/CPP/type_traits/is_array.h"
+#include "src/__support/CPP/type_traits/is_class.h"
+#include "src/__support/CPP/type_traits/is_scalar.h"
+#include "src/__support/CPP/type_traits/is_union.h"
+#include "src/__support/macros/attributes.h"
+
+namespace __llvm_libc::cpp {
+
+// is_object
+template <class T>
+struct is_object
+    : cpp::bool_constant<cpp::is_scalar_v<T> || cpp::is_array_v<T> ||
+                         cpp::is_union_v<T> || cpp::is_class_v<T>> {};
+template <class T>
+LIBC_INLINE_VAR constexpr bool is_object_v = is_object<T>::value;
+
+} // namespace __llvm_libc::cpp
+
+#endif // LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 3680ee730e72d54..17e4913749d51c6 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -309,6 +309,7 @@ libc_support_library(
         "src/__support/CPP/type_traits/is_lvalue_reference.h",
         "src/__support/CPP/type_traits/is_member_pointer.h",
         "src/__support/CPP/type_traits/is_null_pointer.h",
+        "src/__support/CPP/type_traits/is_object.h",
         "src/__support/CPP/type_traits/is_pointer.h",
         "src/__support/CPP/type_traits/is_reference.h",
         "src/__support/CPP/type_traits/is_rvalue_reference.h",

>From 91996af99a53fe95f15cd4345c12f063f1ba34f0 Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet <gchatelet at google.com>
Date: Mon, 11 Sep 2023 14:32:33 +0000
Subject: [PATCH 2/3] Add is_object to CMakeLists.txt

---
 libc/src/__support/CPP/CMakeLists.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libc/src/__support/CPP/CMakeLists.txt b/libc/src/__support/CPP/CMakeLists.txt
index e3cc6b3633839ec..d24c023ec28ebc9 100644
--- a/libc/src/__support/CPP/CMakeLists.txt
+++ b/libc/src/__support/CPP/CMakeLists.txt
@@ -118,6 +118,7 @@ add_header_library(
     type_traits/is_lvalue_reference.h
     type_traits/is_member_pointer.h
     type_traits/is_null_pointer.h
+    type_traits/is_object.h
     type_traits/is_pointer.h
     type_traits/is_reference.h
     type_traits/is_rvalue_reference.h

>From 78306e2b2fc9b6e3a302097a144747a04fcb73f5 Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet <gchatelet at google.com>
Date: Mon, 11 Sep 2023 14:32:50 +0000
Subject: [PATCH 3/3] Add tests for is_object

---
 .../src/__support/CPP/type_traits_test.cpp    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/libc/test/src/__support/CPP/type_traits_test.cpp b/libc/test/src/__support/CPP/type_traits_test.cpp
index a48d646d29e5c45..cd025f588388d68 100644
--- a/libc/test/src/__support/CPP/type_traits_test.cpp
+++ b/libc/test/src/__support/CPP/type_traits_test.cpp
@@ -253,6 +253,28 @@ TEST(LlvmLibcTypeTraitsTest, is_enum_enum) {
 
 // TODO is_null_pointer
 
+TEST(LlvmLibcTypeTraitsTest, is_object) {
+  EXPECT_TRUE((is_object_v<int>));      // scalar
+  EXPECT_TRUE((is_object_v<Struct[]>)); // array
+  EXPECT_TRUE((is_object_v<Union>));    // union
+  EXPECT_TRUE((is_object_v<Class>));    // class
+
+  // pointers are still objects
+  EXPECT_TRUE((is_object_v<int *>));       // scalar
+  EXPECT_TRUE((is_object_v<Struct(*)[]>)); // array
+  EXPECT_TRUE((is_object_v<Union *>));     // union
+  EXPECT_TRUE((is_object_v<Class *>));     // class
+
+  // reference are not objects
+  EXPECT_FALSE((is_object_v<int &>));       // scalar
+  EXPECT_FALSE((is_object_v<Struct(&)[]>)); // array
+  EXPECT_FALSE((is_object_v<Union &>));     // union
+  EXPECT_FALSE((is_object_v<Class &>));     // class
+
+  // not an object
+  EXPECT_FALSE((is_object_v<void>));
+}
+
 // TODO is_pointer
 
 // TODO is_reference