[PATCH] D159485: [DebugInfo][RemoveDIs] Use getStableDebugLoc when picking IRBuilder source locations

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 07:26:32 PDT 2023


Orlando added a comment.

LGTM, including agreeing with your assessment of and changes to `llvm/test/CodeGen/AMDGPU/llvm.dbg.value.ll` (comments from @arsenm or @scott.linder to confirm would still be welcome of course, if either of you have the bandwidth)



================
Comment at: llvm/test/Instrumentation/HWAddressSanitizer/RISCV/alloca.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals --version 2
 ; Test alloca instrumentation.
 ;
----------------
Worth duplicating the comment you added to the other similar hwasan test IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159485/new/

https://reviews.llvm.org/D159485



More information about the llvm-commits mailing list