[llvm] [NVPTX] Remove NOP definition (PR #65967)

via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 07:12:18 PDT 2023


https://github.com/ldrumm created https://github.com/llvm/llvm-project/pull/65967:

PTX has no NOP instruction, and it's unused anywhere in the compiler. This looks like it might have been added for machine scheduling, but it looks unused.

If we eventually need it, we can add it back.

>From 0d8814a4cff658829ad3d7382db1df71c44a95f1 Mon Sep 17 00:00:00 2001
From: Luke Drummond <luke.drummond at codeplay.com>
Date: Mon, 11 Sep 2023 14:13:28 +0100
Subject: [PATCH] [NVPTX] Remove NOP definition

PTX has no NOP instruction, and it's unused anywhere in the compiler.
This looks like it might have been added for machine scheduling, but
it looks unused.

If we eventually need it, we can add it back.
---
 llvm/lib/Target/NVPTX/NVPTXInstrInfo.td | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td b/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
index d1c75f8bea89bc2..3e48c0f9d2c6ab0 100644
--- a/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
+++ b/llvm/lib/Target/NVPTX/NVPTXInstrInfo.td
@@ -12,11 +12,6 @@
 
 include "NVPTXInstrFormats.td"
 
-// A NOP instruction
-let hasSideEffects = false in {
-  def NOP : NVPTXInst<(outs), (ins), "", []>;
-}
-
 let OperandType = "OPERAND_IMMEDIATE" in {
   def f16imm : Operand<f16>;
   def bf16imm : Operand<bf16>;



More information about the llvm-commits mailing list