[PATCH] D158882: RegisterCoalescer: Don't delete IMPLICIT_DEF if it's live into the same block

Mon Sep 11 05:48:27 PDT 2023

bjope added a comment.

I'm confused. In "Diff 2" (that now is approved) the things you did in "Diff 1" was removed,
The "diff against base" now seem to show the diff compared to the base of D158850 <https://reviews.llvm.org/D158850>. Which is a not-yet-approved patch prio to this in the patch stack.

So something seems really weird to me. Should this patch perhaps be rebased on top of D158850 <https://reviews.llvm.org/D158850>?  And what about the original code changes that were in here before the "squash test" update?

(I still expect that this patch would change the RUN line in llvm/test/CodeGen/X86/pr38795.ll to enable -verify-machineinstrs as part of solving PR39440 == GH issue 38788. Right?)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158882/new/

https://reviews.llvm.org/D158882