[lld] [ELF] Respect orders of symbol assignments and DEFINED (PR #65866)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 11 05:47:10 PDT 2023


================
@@ -86,9 +86,10 @@ struct SectionCommand {
 
 // This represents ". = <expr>" or "<symbol> = <expr>".
 struct SymbolAssignment : SectionCommand {
-  SymbolAssignment(StringRef name, Expr e, std::string loc)
+  SymbolAssignment(StringRef name, Expr e, std::string loc,
+                   unsigned symOrder = 0)
----------------
smithp35 wrote:

There are only a couple more calls to the constructor in the same file. Would it be better to make the index explicit at the call site?

Not a strong opinion, and happy for it to be left as is.

https://github.com/llvm/llvm-project/pull/65866


More information about the llvm-commits mailing list