[PATCH] D152537: [NFC][DebugInfo][RemoveDIs] Prefer insert-with-iterator over instruction pointers when inserting into blocks

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Cheers; corrections applied when landing. I've merged in getFirstNonPHIIt in this patch from an earlier approved one, as the earlier one has extra dependencies.



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2154-2155
     Builder.SetInsertPoint(LbCond);
-    Instruction *TcDec = cast<Instruction>(
-        Builder.CreateSub(TcPhi, ConstantInt::get(Ty, 1),
-                          "tcdec", false, true));
+    Instruction *TcDec = cast<Instruction>(Builder.CreateSub(
+        TcPhi, ConstantInt::get(Ty, 1), "tcdec", false, true));
 
----------------
Orlando wrote:
> nit: Looks like this bit has just been reformatted? Possibly should be left unchanged, but not a strong opinion. 
To confirm, yup that's clang-format doing stuff, I'll undo it to avoid future archaeologists being confused


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152537/new/

https://reviews.llvm.org/D152537