[PATCH] D139074: Vectorization Of Conditional Statements Using BOSCC

Sun Sep 3 23:45:29 PDT 2023

Ashutosh marked 15 inline comments as done.
Ashutosh added inline comments.

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:207
+static cl::opt<unsigned> BOSCCInstructionInBlockThreshold(
+    "boscc-instructions-in-threshold", cl::init(5), cl::Hidden,
+    cl::desc("The minimum instructions in a block required for boscc"));
----------------
Matt wrote:
> I'm curious about the difference from AOCC here. Context: My understanding (from the EuroLLVM 2023) talk is that this has been already implemented in AOCC before. I'm wondering, were the cost model decisions / profitability analysis the same? I'm curious about it in the context of the (already resolved) ICE--is it possible that AOCC was able to avoid running into an ICE whereas this patch previously exposed a possibly missing precondition/assumption (could there be any more follow-on issues?)
Thanks for the review Mat. Unfortunately the reported ICE was due to some design changes made to upstream this change. I don’t anticipate further issues with this change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139074/new/

https://reviews.llvm.org/D139074