[compiler-rt] 360d677 - [compiler-rt] Link atomic against builtins (#65239)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 3 22:45:15 PDT 2023
Author: Petr Hosek
Date: 2023-09-03T22:45:11-07:00
New Revision: 360d67730a0a62d8cb845a45f3490a5aad36e49d
URL: https://github.com/llvm/llvm-project/commit/360d67730a0a62d8cb845a45f3490a5aad36e49d
DIFF: https://github.com/llvm/llvm-project/commit/360d67730a0a62d8cb845a45f3490a5aad36e49d.diff
LOG: [compiler-rt] Link atomic against builtins (#65239)
The atomic shared library needs to be linked against builtins. The
`add_compiler_rt_runtime` call already has `DEP builtins` but that only
ensures that the `builtins` target is built before `clang_rt.atomic` but
doesn't link against `clang_rt.builtins`, to do so we need to use
`LINK_LIBS clang_rt.builtins`.
Added:
Modified:
compiler-rt/lib/builtins/CMakeLists.txt
Removed:
################################################################################
diff --git a/compiler-rt/lib/builtins/CMakeLists.txt b/compiler-rt/lib/builtins/CMakeLists.txt
index 727bcab436e2a8..43ef62ffb115d9 100644
--- a/compiler-rt/lib/builtins/CMakeLists.txt
+++ b/compiler-rt/lib/builtins/CMakeLists.txt
@@ -878,7 +878,7 @@ if(COMPILER_RT_BUILD_STANDALONE_LIBATOMIC)
ARCHS ${arch}
SOURCES atomic.c
LINK_FLAGS ${COMPILER_RT_LIBATOMIC_LINK_FLAGS}
- DEPS builtins
+ LINK_LIBS clang_rt.builtins-${arch}
PARENT_TARGET builtins-standalone-atomic)
endif()
endforeach()
More information about the llvm-commits
mailing list