[PATCH] D155940: [SimplifyCFG] Transform for redirecting phis between unmergeable BB and SuccBB

[DianQK via Phabricator via llvm-commits]

DianQK added a comment.

I read the history of jump-table-islands.ll.
This test checks for oversized jump tables jumping over each other.
You transform changes from

  end:                                              ; preds = %complex, %simple
    %val = phi i8500 [ %l, %complex ], [ -1, %simple ]
    br label %common.ret

to

  end:                                              ; preds = %complex
    br label %common.ret

The test was to check disappears.
Increasing `BigInt` makes no sense.
Sorry I don't know how to create a friendly diff display.
You could  remove `-arm-atomic-cfg-tidy=0` and change the `end` bb to:

  end:
    %val = phi %BigInt [ %l, %complex ], [ -1, %simple ]
    %val2 = add %BigInt %val, 1
    ret %BigInt %val2
  }

https://reviews.llvm.org/differential/diff/555646/

I feel the `SKIP_TABLE` name is confusing and should be changed to `CONTINUE_TABLE`/`ISLAND_JUMP`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155940/new/

https://reviews.llvm.org/D155940