[PATCH] D159406: [SelectionDAG] Generalise SelectionDAG::computeOverflowKind to support other opcodes
Mohamed Atef via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 3 12:41:28 PDT 2023
elhewaty added a comment.
I used `git blame` on `SelectionDAG.cpp` and `DAGCombiner.cpp` and found that tests are in `llvm/test/CodeGen/X86/xaluo.ll` does this mean that I should modify `xaluo.ll` and `xmulo.ll`? are the tests autogenerate no manual tests needed? am I even on the right track?
I discovered I should modify `xmulo.ll`, `vec_smulo.ll` and `xaluo.ll`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159406/new/
https://reviews.llvm.org/D159406
More information about the llvm-commits
mailing list