[PATCH] D158864: [Code Coverage] Add a script to check code coverage of a patch

Shivam Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 3 05:18:12 PDT 2023


xgupta added inline comments.


================
Comment at: llvm/utils/git-check-coverage:176
+            if "test" in test_file:
+                if match.group(0).startswith("+++"):
+                    added_tests.append(test_file)
----------------
hnrklssn wrote:
> How will this not always be the case, given that the match comes from `r"^\+\+\+ [ab]/(.*\.ll)$"`?
Parsing list of test cases will be handled by lit, will remove this in the next update. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158864/new/

https://reviews.llvm.org/D158864



More information about the llvm-commits mailing list