[PATCH] D149757: Test data for symbol lookup. NFC

Sat Sep 2 02:57:15 PDT 2023

sepavloff added a comment.

I don't think building test binaries in test time is possible for this particular case. The tests using the binary from here expect symbols at concrete locations. If something in code generation changes, and the locations become different, the tests would fail.

In D149757#4549272 <https://reviews.llvm.org/D149757#4549272>, @ikudrin wrote:

> This patch only adds files to be used in another patch. It does not change any code or add any new tests and has no value of its own. It should be merged with the main patch, or relevant parts of D149759 <https://reviews.llvm.org/D149759> should be moved here, whichever is preferable.

You are right, these changes are a part of D149759 <https://reviews.llvm.org/D149759>. They are however independent of it and moving them to a separate patch could facilitate the review process.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149757/new/

https://reviews.llvm.org/D149757