[PATCH] D149757: Test data for symbol lookup. NFC

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D149757#4630300 <https://reviews.llvm.org/D149757#4630300>, @jhenderson wrote:

> In D149757#4630137 <https://reviews.llvm.org/D149757#4630137>, @MaskRay wrote:
>
>> I wonder whether these files should go to cross-project-tests/
>
> One of my original motivations for making cross-project-tests included finding a good way to runtime generate llvm-symbolizer test inputs (see https://lists.llvm.org/pipermail/llvm-dev/2021-January/148048.html), rather than relying on canned binaries, so I agree that it's likely a good idea to move those sorts of tests.

Conversely, all features should be tested in the subproject - cross-project-tests can be for broader integration testing, but it shouldn't mean we see code changes in subprojects without tests in those subprojects. If these tests are the "wider" sort of testing - testing interactions between different parts of the code, where the parts are tested each in isolation in the subproject, then that seems OK to me to move these wider tests out to cross-project-tests.

(maybe that's a formalization of the heuristic: All code should be covered, ideally all conditions should be falsifiable (eg: if you add a `!` in some condition, a test should fail - though I understand this is a fairly high/lofty/not-often-achieved goal) by in-subproject tests, but checking that codepath A1 interacts well with codepath B2 <https://reviews.llvm.org/B2> may be more suitably done in cross-project-tests, for instance)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149757/new/

https://reviews.llvm.org/D149757