[PATCH] D159379: [InstCombine] Baseline tests for folding ((A&B)^A)|((A&B)^B) to A^B

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/or-xor-xor.ll:99
+  %or = or i1 %xor1, %xor2
+  ret i1 %or
+}
----------------
Can you:
1) swap the order of the `and i1 %a, %b` in half the tests.
2) make a/b binops i.e something like:
```
define i1 @foo(%aa, %bb, %cc) {
   %a = xor i1 %aa, %cc
   %b = xor i1 %bb, %cc
}
```
then swap around order of ops in the `xor` in some of the tests.


Also `i1` is a bit of a special case. can you change tests to i8?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159379/new/

https://reviews.llvm.org/D159379