[PATCH] D154294: [Windows SEH]: Do not fold branches for MSVC TableSEH function

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> That would be feasible. However, if we built the edges from all BBs in try region to catchpad, the CFG may turn into a too complex graph to understand for developers who don't know much about SEH. Instead, I think it would be much clear if we taking state numbers into account just when doing CFG optimization.

The CFG becomes more complicated in the sense that there are more edges... but it becomes simpler in the sense that code which generically supports EH pads should just work without additional SEH-specific knowledge.  The latter property seems more valuable because most people working on the backend know nothing about SEH.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154294/new/

https://reviews.llvm.org/D154294