[PATCH] D112290: [Attributor] Look through indirect calls

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 14:06:24 PDT 2023


jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3303
   /// Return true if this AA requires a "callee" (or an associted function) for
   /// a call site positon. Default is optimistic to minimize AAs.
+  static bool requiresCalleeForCallBase() { return false; }
----------------
tianshilei1992 wrote:
> I thought the optimistic condition would be we don't have indirect calls such that the "callee" is required.
It's not about optimistic per se. This is a way to avoid creating AAs that will  result in a pessimistic fixpoint right away. With this change, most AAs use `checkForAllCallees` via `AACalleeToCallSite` and therefore will be able to cope with "missing"/"non-unique" callees.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112290/new/

https://reviews.llvm.org/D112290



More information about the llvm-commits mailing list