[PATCH] D159380: [InstCombine] Fold ((A&B)^A)|((A&B)^B) to A^B

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 14:02:54 PDT 2023


goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:3669
+    }
+  }
+
----------------
1) the `m_Xor` -> `m_c_Xor`
2) Put this in a lambda so you don't need to duplicate the match logic and just do `SomeFuncName(Op0, Op1)` / `SomeFuncName(Op1, Op0)`.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159380/new/

https://reviews.llvm.org/D159380



More information about the llvm-commits mailing list