[PATCH] D157977: [InstCombine] OptimizePointerDifference when a gep has phi ptr

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added a comment.

Can you add alive2 links?



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineInternal.h:97
+  Value *OptimizePointerDifference(Value *LHS, Value *RHS, Type *Ty,
+                                   BinaryOperator &I, bool isNUW);
   Instruction *visitSub(BinaryOperator &I);
----------------
nit: Can you put this decl a bit later in the file? (After the block of visit*)


================
Comment at: llvm/test/Transforms/InstCombine/sub-gep.ll:472
+  ret i1 %tobool
+}
----------------
Can you precommit tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157977/new/

https://reviews.llvm.org/D157977