[PATCH] D144872: [AIX] Align the content of an xcoff object file which has auxiliary header in big archive.

[Digger Lin via Phabricator via llvm-commits]

DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/test/Object/archive-malformed-object.test:16
+# RUN: rm -rf bad.a
+# RUN: not llvm-ar rcS bad.a xcoff.o input.bc 2>&1 | FileCheck %s --check-prefix=ERR1
+
----------------
jhenderson wrote:
> I'm pretty sure you don't want the `S` here? Compare this command to the one above. If you are using a non-big archive format (which will be the default on many people's systems), then the symbols are only loaded if `S` is not present. If the symbols aren't loaded, the bitcode file won't result in an error (I think).
 I need to `S` to test your comment ,  the archive format always depend on the first object file of llvm-ar argument(no matter the OS). when the xcoff object file, the archive is big archive.
  
`Ideally, you would also have a test case that shows that when no symbols are requested (i.e. llvm-ar S<more options> test.a xcoff.o), an error is also reported for an invalid member of a big archive.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144872/new/

https://reviews.llvm.org/D144872