[PATCH] D157459: Make DWARFContext more thread safe.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h:135
   DWARFContext(std::unique_ptr<const DWARFObject> DObj,
+               bool EnableMultiThreading,
                std::string DWPName = "",
----------------
JDevlieghere wrote:
> How about `bool ThreadSafe`?
works for me


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:246
+
+class SingleThreadedState : public DWARFContext::DWARFContextState {
+
----------------
JDevlieghere wrote:
> How about `UnsafeDWARFContextState`? 
Following your previous suggestion maybe "ThreadUnsafeDWARFContextState"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157459/new/

https://reviews.llvm.org/D157459