[PATCH] D159223: [llvm-windres] Implement the windres flag --use-temp-file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 1 08:41:35 PDT 2023

mstorsjo added a comment.

In D159223#4634441 <https://reviews.llvm.org/D159223#4634441>, @mati865 wrote:

> Let's get this regression fixed

Technically this bit isn't a regression - I just hadn't realized that `--use-temp-file` inhibits the messier parts of the windres interface (and hadn't run into projects using it before). But for other reasons, a project that wanted to use `--use-temp-file` but couldn't use it with llvm-windres, had used a different parameter passing which was broken by 0f4c6b120f21d582ab7c5c4f2b2a475086c34938 <https://reviews.llvm.org/rG0f4c6b120f21d582ab7c5c4f2b2a475086c34938> / D146848 <https://reviews.llvm.org/D146848> - where this option made llvm-windres match GNU windres better.

So no regression, but for this usecase we placed that particular user of the tool in a tricky spot - correctly implementing this option gives a better way forward. (This issue has normally been solved by double-escaping parameters to windres elsewhere - but the use in xz where the same defines are passed both to windres and to the C compiler breaks if using that double-escaping fix.)

> but I'm also curious about the plan for future ``--preprocessor` changes.

I guess I could look into changing it to the new behaviour form at some point. But as the referenced bugzilla thread shows, it was all left in a bit of undefined state (attempts to revert something to appease some users, but actually reverting the wrong thing, etc...)

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list