[PATCH] D159223: [llvm-windres] Implement the windres flag --use-temp-file

[Alvin Wong via Phabricator via llvm-commits]

alvinhochun accepted this revision.
alvinhochun added a comment.
This revision is now accepted and ready to land.

The code looks fine to me, and I trust that you have tested it.



================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:496-497
   }
+  // TODO: If --use-temp-file is set, we shouldn't be unescaping
+  // the --preprocessor argument either, only splitting it.
   if (InputArgs.hasArg(WINDRES_preprocessor))
----------------
I presume you plan to resolve this soon? Since you mentioned that GNU windres changed its behaviour in a backwards incompatible
way do you have a reference to any upstream bug reports or commits regarding this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159223/new/

https://reviews.llvm.org/D159223