[PATCH] D145281: [InstCombine] Add transforms for `(icmp spred (or X, Y), X)`

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:4493
+  auto KnownSign = getKnownSign(A, &I, Q.DL, Q.AC, Q.DT);
+  if (KnownSign != std::nullopt) {
+    // icmp (X | MinInt) s> X --> false
----------------
Maybe move this into the if() to reduce scope
```
if (auto KnownSign = getKnownSign(A, &I, Q.DL, Q.AC, Q.DT))
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145281/new/

https://reviews.llvm.org/D145281