[PATCH] D158992: [VPlan] Manage compare predicates in VPRecipeWithIRFlags.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 6 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:49
+  /// Insert \p VPI in BB at InsertPt if BB is set.
+  VPInstruction *insertInstruction(VPInstruction *VPI) {
+    if (BB)
----------------
Ayal wrote:
> nit: tryInsertInstruction?
Adjusted, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:904
 
+  template <typename IterT>
+  VPRecipeWithIRFlags(const unsigned char SC, IterT Operands,
----------------
Ayal wrote:
> nit: place this first as well
Moved, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:993
 
+  CmpInst::Predicate getPredicate() const {
+    assert(OpType == OperationType::Cmp &&
----------------
Ayal wrote:
> nit: let Cmp appear first consistently
Moved, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1071
 
+  VPInstruction(unsigned Opcode, CmpInst::Predicate Pred, VPValue *A,
+                VPValue *B, DebugLoc DL = {}, const Twine &Name = "");
----------------
Ayal wrote:
> nit: ditto
Moved, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:258
 
+VPInstruction::VPInstruction(unsigned Opcode, CmpInst::Predicate Pred,
+                             VPValue *A, VPValue *B, DebugLoc DL,
----------------
Ayal wrote:
> nit: ditto
Moved, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:283
   }
-  case VPInstruction::ICmpULE: {
+  case Instruction::FCmp:
+  case Instruction::ICmp: {
----------------
Ayal wrote:
> nit: FCmp is currently dead?
dropped, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158992/new/

https://reviews.llvm.org/D158992