[PATCH] D159331: [ADT][NFC] Remove some redundant code

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 31 23:31:40 PDT 2023


MaskRay added a comment.

In D159331#4633453 <https://reviews.llvm.org/D159331#4633453>, @yuntaopan wrote:

> @MaskRay  is_one_of and are_base_of have been defined in llvm/include/llvm/ADT/STLExtras.h lines 210 to 218, so delete the duplicate code starting at line 1487

So we have `llvm::detail::are_base_of` and `llvm::are_base_of`. The use in `llvm/include/llvm/IR/DerivedTypes.h` is `llvm::are_base_of` which you are removing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159331/new/

https://reviews.llvm.org/D159331



More information about the llvm-commits mailing list