[PATCH] D159333: [RISCV] Replace RISCVVInversePseudosTable with a SearchIndex

[Wang Pengcheng via Phabricator via llvm-commits]

wangpc added a comment.

In D159333#4633363 <https://reviews.llvm.org/D159333#4633363>, @craig.topper wrote:

> In D159333#4633354 <https://reviews.llvm.org/D159333#4633354>, @wangpc wrote:
>
>> In D159333#4633304 <https://reviews.llvm.org/D159333#4633304>, @michaelmaitland wrote:
>>
>>> It looks like the InversePseudo table was only included for MCA directory. I wonder if this led to it only being a part of the llvm-mca binary, and not part of tools that do not depend on llvm-mca (such as llc). Could you check this by comparing the size of llc binary? It should have gotten larger after this change if it had not previously included the InversePseudo table.
>>
>> Yes, the size will increase about 100KB for llc.
>> My intention is to unify the table (and make the code more consistent?). And if we can get SEW of pseudos from this table, then we don't need to specify the explict SEW imm in pseudos' operands (WIP).
>> For example:
>>
>>   class VPseudoUSLoadNoMask<VReg RetClass,
>>                             int EEW> :
>>         Pseudo<(outs RetClass:$rd),
>>                (ins RetClass:$dest, GPRMem:$rs1, AVL:$vl, ixlenimm:$sew,
>>                     ixlenimm:$policy), []>
>>
>> becomes:
>>
>>   class VPseudoUSLoadNoMask<VReg RetClass,
>>                             int EEW> :
>>         Pseudo<(outs RetClass:$rd),
>>                (ins RetClass:$dest, GPRMem:$rs1, AVL:$vl,
>>                     ixlenimm:$policy), []>,
>>
>> This may simplify the generated patterns I think.
>
> Won't that require adding more pseudos for each SEW. Many pseudos don't have SEW today.

I think almost all pseudos has `HasSEWOp` being true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159333/new/

https://reviews.llvm.org/D159333