[PATCH] D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0)

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:7665-7666
     } else {
+      // Global addresses can also be folded, but only if they are sufficiently
+      // aligned.
+      if (RequiresMod4Offset) {
----------------
Suggested wording change.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:3360
+        if (GVType->isSized() && !GVType->isEmptyTy() &&
+            GV->getParent()->getDataLayout().getTypeAllocSize(GVType) <
+                AIXSmallTlsPolicySizeLimit)
----------------
hubert.reinterpretcast wrote:
> Sorry for the extra churn: with the new name, we should use `<=` here (and adjust the value to `32751`).
This comment has not been addressed.


================
Comment at: llvm/lib/Target/PowerPC/PPCMCInstLower.cpp:97
+  else if (MO.getTargetFlags() == PPCII::MO_TPREL_FLAG) {
+    assert(MO.isGlobal() && "Only expecting a global MachineOperand here!\n");
+    TLSModel::Model Model = TM.getTLSModel(MO.getGlobal());
----------------
hubert.reinterpretcast wrote:
> `assert`s print the spelling of the expression, so the `\n` is not needed.
This comment has not been addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155600/new/

https://reviews.llvm.org/D155600